-
Notifications
You must be signed in to change notification settings - Fork 452
Separate downloading and unpacking prometheus archive #102
Conversation
Thanks for the blasting fast fixing. I tried the fix, and with two minor modifications, it works correctly. The changes are:
|
Thinking about this, can we download these archives to something like |
@taiansu your modifications would change how we want this role to work. If we add |
@SuperQ we could probably use |
@taiansu can you tell what is not working in current version? Some error messages could be useful. |
One other nice thing, it would be good to cache this so it doesn't download the file every time. In theory, we could extract the checksum from the sums published on github. |
@SuperQ I agree that it would be nice to validate checksums. This option is even provided in |
Yes I understand that will change the behaviour. If I apply the changes as is, the first error I got is like:
And adding |
@taiansu this should be fixed now, could you test it? |
@SuperQ I don't think we can use other directories on deployer machine apart from |
For me, it's required install libselinux-python and work fine |
I tried the fix, but I got the simillar error back to the first point:
So I'm wondering the error may not be relate to the separate the download and unarchve, but rather we just can't unarchive a linux tar in the host while it's a Mac. Anyway thanks for all the help. |
@taiansu yes it seems that there is a problem with
Could you check if after installing
|
It works. Thanks so much! |
Great! |
Should we also update the Requiremets in the README? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
[patch] Separate downloading and unpacking prometheus archive
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Resolves #101
Possibly accidentally solves ans issue with too many downloads of prometheus archive to localhost.