Catch errors when initializing message_store #707
+278
−12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kickster97
force-pushed
the
error-state-for-queues
branch
2 times, most recently
from
92f6dad
to
e268a1c
Compare
kickster97
changed the title
To let LavinMQ start up even if there are corrupt messages in msg_store
kickster97
force-pushed
the
error-state-for-queues
branch
from
67d5b76
to
5a0dff7
Compare
kickster97
requested review from
carlhoerberg,
snichme,
spuun and
viktorerlingsson
as code owners
…e, and clear segments when closing msg_store
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WHAT is this pull request doing?
This PR adds that we catch error when reading segments, to let LavinMQ start up even if we have corrupted messages in a msg_store segment.
It introduces
opentoqueue.cr, which allows you to manually try to open the queue again after solving the errors. (you no longer have to restart LavinMQ)Also improves the logging by logging the reason of closing the
queue/message_store, then saves the exception as@closed_reasoninqueueandmessage_storeand exports it to the ui viadetails_tupleHave some polishing to do, but the basic idea is there so i thought i'd open the pr to get some feedback
TODO: make UI make sense
wip
HOW can this pull request be tested?
there is a spec for the open method