Fix double eval #16
Merged
Fix double eval #16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closing persistent connections on timeout has generated a bit of confusion. I've gone ahead and silenced the log message.
This was a race condition causing flaky unit tests.
If a context initialization failed it would take down ateles_server. If enough failed fast enough it would cascade to the entire app and then Erlang VM.
These will also be logged so we can debug the double eval issue.
This is debug logging to be removed when we figure out the double eval issue.
nickva
approved these changes
May 21, 2020
chewbranca
approved these changes
May 21, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Minimize the impact of errors in ateles_server when creating JS contexts fails. Also add logging to attempt to diagnose why those errors are happening in the first place. And a couple unit test fixes exposed by running on Erlang 22.