This repository has been archived by the owner on Mar 11, 2022. It is now read-only.
Prepare for 2.13.0 release #449
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ricellis
suggested changes
Jun 7, 2018
|
|
||
| } | ||
| /* | ||
| * Copyright (c) 2015, 2018 IBM Corp. All rights reserved. |
| * <p> | ||
| * <b>Important:</b>Top-level field names that begin with the underscore character (_) are | ||
| * <a href="https://console.bluemix.net/docs/services/Cloudant/api/document.html#documents" target="_blank"> | ||
| * reserved</a> in Cloudant and must not be used. |
There was a problem hiding this comment.
I think we should append something like...
If you wish to control the reserved properties e.g. _id _rev and _deleted or map them to specific fields in your POJO then do not subclass com.cloudant.client.api.model.Document, but use your own class instead.
CHANGES.md
Outdated
| - [FIXED] An issue where `getReason()` returned an incorrect value for `Response` objects returned | ||
| by `Database.bulk()`. | ||
| - [FIXED] Issues retrieving deleted documents using an `AllDocsRequest`. | ||
| - [BREAKING CHANGE] Added `_deleted` field to `Document`. This will break (de)serialisation for | ||
| classes which sub-class `Document` and themselves declare a a field which implicitly or explicitly |
There was a problem hiding this comment.
duplicated a in declare a a field
CHANGES.md
Outdated
| - [FIXED] An issue where `getReason()` returned an incorrect value for `Response` objects returned | ||
| by `Database.bulk()`. | ||
| - [FIXED] Issues retrieving deleted documents using an `AllDocsRequest`. | ||
| - [BREAKING CHANGE] Added `_deleted` field to `Document`. This will break (de)serialisation for |
There was a problem hiding this comment.
Maybe we can split this into two, since really there is an actual fix here and the "breaking change" is really more of a side effect for edge cases:
- [FIXED] Added missing `_deleted` field to `Document` model class.
- [BREAKING CHANGE] The fix for adding the `_deleted` field will break...
ricellis
approved these changes
Jun 8, 2018
smithsz
approved these changes
Jun 8, 2018
emlaver
approved these changes
Jun 8, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.