This repository has been archived by the owner on Aug 30, 2024. It is now read-only.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
CHANGES.md
|CHANGELOG.md
) or test/build only changesDescription
This PR implements a
Document.atomic
context manager that don't save a document if there is any uncatched exception in inner code block. Tentatively fixes #427.Approach
As this change could be breaking (in fact it change a default behaviour) I've decided to implement a brand new context manager using python's contextlib.
When it's needed, one could use
atomic
as a context manager:Context Manager implementation follow current one, in fact it uses the same dunders.
Schema & API Changes
Document.atomic
context managerSecurity and Privacy
Testing
Monitoring and Logging