Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DevOps World | Jenkins World 2019 demo config #9

Closed
wants to merge 5 commits into from

Conversation

MarkEWaite
Copy link
Contributor

Commented a few items to reduce warnings at startup. Avoid the noise during the presentation while leaving the configurations as comments.

@@ -0,0 +1,2 @@
# Treat all text files without a CR (as we have Docker)
* text eol=lf
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why don't you just make it a default setting on your machine?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If other Windows users want to build the demo, they will be broken without this setting. Making it global on my machine is too broad a change to support this demo.

Copy link
Contributor

@oleg-nenashev oleg-nenashev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some changes need to be reverted IMO, especially te commented agent and cloud configurations. There is no intention of having a clean demo ATM

@@ -1,6 +1,6 @@
jenkins:
agentProtocols:
- "JNLP2-connect"
# - "JNLP2-connect"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Either remove it or add a comment. I added protocol to showcase that you can override Jenkins defaults, this demo will indeed showing a security warning. But this is fine with me

Suggested change
# - "JNLP2-connect"
# Demonstrates that a disabled protocol can be enabled via JCasC. Note that it will lead to the administrative warning
- "JNLP2-connect"

@@ -42,7 +42,7 @@ jenkins:
- id: "admin"
password: "admin"
slaveAgentPort: 50000
systemMessage: "This is a demo CJD instance for Jenkins Configuration-as-Code"
systemMessage: "<h1><a href='https://www.cloudbees.com/products/cloudbees-jenkins-distribution'>CloudBees Jenkins Distribution</a> with <a href='https://jenkins.io/projects/jcasc/'>Configuration-as-Code</a></h1><br>Technical preview"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

internalDir: "remoting"
name: "Java Web Start Agent"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we should finally rename it in the core. CC @jeffret-b

retentionStrategy: "always"
- permanent:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why? Fine for demo

numExecutors: 2
retentionStrategy: "always"
clouds:
- amazonEC2:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why? Needed for demos and smoke testing

branches:
- "mybranch-3"
- "mybranch-4"
# submoduleCfg:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why? it works with the current plugin versions

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Didn't work in the environment that I was using. I suspect the outdated plugin from CAP was being used instead of the version described in plugins.txt

@MarkEWaite MarkEWaite closed this Aug 19, 2019
@MarkEWaite
Copy link
Contributor Author

MarkEWaite commented Aug 19, 2019

Replaced by #11, #12 , #13, #14, #15, and #16. I intentionally structured them so that you may reject any of them or select any of them, independent of one another. Thanks for letting me use your demo repo!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants