Adjust the method of loading the external preloaded shared libraries #155
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
External lib is preloaded. Need to write to theprocess_shared_preload_libraries.h header file. This loads the external lib through the header file.
|
|
my-ship-it
previously approved these changes
Aug 21, 2023
yjhjstz
reviewed
Aug 21, 2023
yjhjstz
reviewed
Aug 21, 2023
|
src/include/utils/process_shared_preload_libraries.h is empty ? |
|
This one is expand on the new features. Load the dynamic library through the header file. |
yjhjstz
reviewed
Aug 22, 2023
Extended String. To load the dynamic library is deduplicate
|
Hi @MisterRaindrop: Thanks for your contribution! Please use "rebase" instead of "merge" for your commits to stay up to date with the main branch. For a good commit title and message body, please follow our commit conventions, which can make our history easy to read. Additionally, please remember to squash your commits down to one. Thank you! |
yjhjstz
reviewed
Aug 31, 2023
yjhjstz
reviewed
Aug 31, 2023
…aindrop/cloudberrydb into adjust_loading_sharedlib
…aindrop/cloudberrydb into adjust_loading_sharedlib
yjhjstz
reviewed
Sep 13, 2023
9 tasks
|
Since PR #242 has been merged, could we close this PR? @MisterRaindrop |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes: #ISSUE_Number
Change logs
Add a new mechanism to pre-load dynamic libraries during database startup. Controlled library inclusion through header files.
External lib is preloaded. Need to write to theprocess_shared_preload_libraries.h header file. This loads the external lib through the header file.
If it has some breaking backward or forward compatibility, please clary.
Why are the changes needed?
Describe why the changes are necessary.
Does this PR introduce any user-facing change?
If yes, please clarify the previous behavior and the change this PR proposes.
How was this patch tested?
Please detail how the changes were tested, including manual tests and any relevant unit or integration tests.
Contributor's Checklist
Here are some reminders and checklists before/when submitting your pull request, please check them:
make installcheckmake -C src/test installcheck-cbdb-parallel