Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adjust the method of loading the external preloaded shared libraries #242

Merged

Conversation

MisterRaindrop
Copy link
Contributor

closes: #ISSUE_Number


Change logs

Add a new mechanism to pre-load dynamic libraries during database startup. Controlled library inclusion through header files.

External lib is preloaded. Need to write to theprocess_shared_preload_libraries.h header file. This loads the external lib through the header file.

Why are the changes needed?

Describe why the changes are necessary.

Does this PR introduce any user-facing change?

If yes, please clarify the previous behavior and the change this PR proposes.

How was this patch tested?

Please detail how the changes were tested, including manual tests and any relevant unit or integration tests.

Contributor's Checklist

Here are some reminders and checklists before/when submitting your pull request, please check them:

  • Make sure your Pull Request has a clear title and commit message. You can take git-commit template as a reference.
  • Sign the Contributor License Agreement as prompted for your first-time contribution(One-time setup).
  • Learn the coding contribution guide, including our code conventions, workflow and more.
  • List your communication in the GitHub Issues or Discussions (if has or needed).
  • Document changes.
  • Add tests for the change
  • Pass make installcheck
  • Pass make -C src/test installcheck-cbdb-parallel
  • Feel free to @cloudberrydb/dev team for review and approval when your PR is ready🥳

yjhjstz
yjhjstz previously approved these changes Oct 18, 2023
External lib is preloaded. Need to write to
theprocess_shared_preload_libraries.h header file. This loads the
external lib through the header file.
Copy link
Contributor

@my-ship-it my-ship-it left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tuhaihe
Copy link
Member

tuhaihe commented Oct 20, 2023

I saw one PR #155 with the same title. After this PR is merged, could we close #155?

@my-ship-it my-ship-it merged commit e82be37 into cloudberrydb:main Oct 30, 2023
6 checks passed
baotingfang pushed a commit that referenced this pull request Dec 1, 2023
…242)

* Adjust the method of loading the external preloaded shared libraries

External lib is preloaded. Need to write to
theprocess_shared_preload_libraries.h header file. This loads the
external lib through the header file.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants