-
Notifications
You must be signed in to change notification settings - Fork 59
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix explain bad indent when showing operatorMem. #288
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Word operatorMem is added by GPDB, it shows bad indent when explain. set gp_resqueue_print_operator_memory_limits=on; explain(costs off) select count(*) from test_hj_spill; QUERY PLAN ---------------------------------------------------------------------------- Finalize AggregateoperatorMem: 100 kB -> Gather Motion 3:1 (slice1; segments: 3)operatorMem: 100 kB -> Partial AggregateoperatorMem: 100 kB -> Seq Scan on test_hj_spilloperatorMem: 100 kB This is introduced by UPSTREAM commit 1001368 which tried to resolve explain indent of parallel query. Add indent manually for CBDB's additional operatorMem. Authored-by: Zhang Mingli avamingli@gmail.com
my-ship-it
approved these changes
Nov 7, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
9 tasks
baotingfang
pushed a commit
that referenced
this pull request
Dec 1, 2023
Word operatorMem is added by GPDB, it shows bad indent when explain. set gp_resqueue_print_operator_memory_limits=on; explain(costs off) select count(*) from test_hj_spill; QUERY PLAN ---------------------------------------------------------------------------- Finalize AggregateoperatorMem: 100 kB -> Gather Motion 3:1 (slice1; segments: 3)operatorMem: 100 kB -> Partial AggregateoperatorMem: 100 kB -> Seq Scan on test_hj_spilloperatorMem: 100 kB This is introduced by UPSTREAM commit 1001368 which tried to resolve explain indent of parallel query. Add indent manually for CBDB's additional operatorMem. Authored-by: Zhang Mingli avamingli@gmail.com
baotingfang
pushed a commit
that referenced
this pull request
Dec 1, 2023
This reverts commit 5a33f73.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is found by #284 during fix cases that require a resource limit option to reproduce when using resource queue.
Word operatorMem is added by GPDB, it shows bad indent when explain.
like
AggregateoperatorMem: 100 kB
This is introduced by UPSTREAM commit 1001368 which tried to resolve explain indent of parallel query.
Add indent manually for CBDB's additional operatorMem.
Authored-by: Zhang Mingli avamingli@gmail.com
fix #ISSUE_Number
Change logs
Describe your change clearly, including what problem is being solved or what feature is being added.
If it has some breaking backward or forward compatibility, please clary.
Why are the changes needed?
Describe why the changes are necessary.
Does this PR introduce any user-facing change?
If yes, please clarify the previous behavior and the change this PR proposes.
How was this patch tested?
Please detail how the changes were tested, including manual tests and any relevant unit or integration tests.
Contributor's Checklist
Here are some reminders and checklists before/when submitting your pull request, please check them:
make installcheck
make -C src/test installcheck-cbdb-parallel
cloudberrydb/dev
team for review and approval when your PR is ready馃コ