Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix explain bad indent when showing operatorMem. #288

Merged
merged 1 commit into from
Nov 7, 2023

Conversation

avamingli
Copy link
Collaborator

@avamingli avamingli commented Nov 6, 2023

This is found by #284 during fix cases that require a resource limit option to reproduce when using resource queue.

Word operatorMem is added by GPDB, it shows bad indent when explain.
like AggregateoperatorMem: 100 kB

set gp_resqueue_print_operator_memory_limits=on;
explain(costs off) select count(*) from test_hj_spill;
                                 QUERY PLAN
----------------------------------------------------------------------------
 Finalize AggregateoperatorMem: 100 kB

       ->  Gather Motion 3:1  (slice1; segments: 3)operatorMem: 100 kB

                 ->  Partial AggregateoperatorMem: 100 kB

                           ->  Seq Scan on test_hj_spilloperatorMem: 100 kB

This is introduced by UPSTREAM commit 1001368 which tried to resolve explain indent of parallel query.

Add indent manually for CBDB's additional operatorMem.

Authored-by: Zhang Mingli avamingli@gmail.com

fix #ISSUE_Number


Change logs

Describe your change clearly, including what problem is being solved or what feature is being added.

If it has some breaking backward or forward compatibility, please clary.

Why are the changes needed?

Describe why the changes are necessary.

Does this PR introduce any user-facing change?

If yes, please clarify the previous behavior and the change this PR proposes.

How was this patch tested?

Please detail how the changes were tested, including manual tests and any relevant unit or integration tests.

Contributor's Checklist

Here are some reminders and checklists before/when submitting your pull request, please check them:

  • Make sure your Pull Request has a clear title and commit message. You can take git-commit template as a reference.
  • Sign the Contributor License Agreement as prompted for your first-time contribution(One-time setup).
  • Learn the coding contribution guide, including our code conventions, workflow and more.
  • List your communication in the GitHub Issues or Discussions (if has or needed).
  • Document changes.
  • Add tests for the change
  • Pass make installcheck
  • Pass make -C src/test installcheck-cbdb-parallel
  • Feel free to request cloudberrydb/dev team for review and approval when your PR is ready馃コ

Word operatorMem is added by GPDB, it shows bad indent when explain.

set gp_resqueue_print_operator_memory_limits=on;
explain(costs off) select count(*) from test_hj_spill;
                                 QUERY PLAN
----------------------------------------------------------------------------
 Finalize AggregateoperatorMem: 100 kB

       ->  Gather Motion 3:1  (slice1; segments: 3)operatorMem: 100 kB

                 ->  Partial AggregateoperatorMem: 100 kB

                           ->  Seq Scan on test_hj_spilloperatorMem: 100 kB

This is introduced by UPSTREAM commit 1001368 which tried to resolve
explain indent of parallel query.

Add indent manually for CBDB's additional operatorMem.

Authored-by: Zhang Mingli avamingli@gmail.com
@avamingli avamingli self-assigned this Nov 6, 2023
Copy link
Contributor

@my-ship-it my-ship-it left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@my-ship-it my-ship-it merged commit 5a33f73 into cloudberrydb:main Nov 7, 2023
6 of 8 checks passed
avamingli added a commit that referenced this pull request Nov 7, 2023
avamingli added a commit that referenced this pull request Nov 7, 2023
avamingli added a commit that referenced this pull request Nov 7, 2023
baotingfang pushed a commit that referenced this pull request Dec 1, 2023
Word operatorMem is added by GPDB, it shows bad indent when explain.

set gp_resqueue_print_operator_memory_limits=on;
explain(costs off) select count(*) from test_hj_spill;
                                 QUERY PLAN
----------------------------------------------------------------------------
 Finalize AggregateoperatorMem: 100 kB

       ->  Gather Motion 3:1  (slice1; segments: 3)operatorMem: 100 kB

                 ->  Partial AggregateoperatorMem: 100 kB

                           ->  Seq Scan on test_hj_spilloperatorMem: 100 kB

This is introduced by UPSTREAM commit 1001368 which tried to resolve
explain indent of parallel query.

Add indent manually for CBDB's additional operatorMem.

Authored-by: Zhang Mingli avamingli@gmail.com
baotingfang pushed a commit that referenced this pull request Dec 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants