Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "Fix explain bad indent when showing operatorMem." #289

Merged
merged 1 commit into from
Nov 7, 2023
Merged

Revert "Fix explain bad indent when showing operatorMem." #289

merged 1 commit into from
Nov 7, 2023

Conversation

avamingli
Copy link
Collaborator

Reverts #288

@avamingli
Copy link
Collaborator Author

ORCA has some failed.

@avamingli avamingli self-assigned this Nov 7, 2023
@tuhaihe
Copy link
Member

tuhaihe commented Nov 7, 2023

Hi @avamingli, For the #288 checks failing, the job also showed when setuping upterm session, sudo: apt-get: command not found. I'm not sure if the workflow should be updated too. Just FYI.

@avamingli
Copy link
Collaborator Author

Hi @avamingli, For the #288 checks failing, the job also showed when setuping upterm session, sudo: apt-get: command not found. I'm not sure if the workflow should be updated too. Just FYI.

I see this on other prs too, May need help from @smartyhero

@avamingli avamingli added the priority: High After critical issues are fixed, these should be dealt with before any further issues. label Nov 7, 2023
@avamingli
Copy link
Collaborator Author

CI failed due to #262

my-ship-it
my-ship-it approved these changes Nov 7, 2023
View reviewed changes
Copy link
Contributor

@my-ship-it my-ship-it left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

gfphoenix78
gfphoenix78 approved these changes Nov 7, 2023
View reviewed changes
Copy link
Collaborator

@gfphoenix78 gfphoenix78 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@avamingli avamingli force-pushed the revert-288-fix_operatorMem_indent branch from 8000358 to 8cd7c5e Compare November 7, 2023 11:32
@avamingli avamingli merged commit 18efaa6 into main Nov 7, 2023
12 checks passed
@avamingli avamingli deleted the revert-288-fix_operatorMem_indent branch November 7, 2023 14:08
@avamingli avamingli mentioned this pull request Nov 9, 2023
Merged
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gfphoenix78 gfphoenix78 gfphoenix78 approved these changes

@my-ship-it my-ship-it my-ship-it approved these changes

Assignees

@avamingli avamingli

Labels
priority: High After critical issues are fixed, these should be dealt with before any further issues.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@avamingli @tuhaihe @gfphoenix78 @my-ship-it