Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Date Value Formatting #5

Closed
wants to merge 2 commits into
from

Conversation

Projects
None yet
2 participants

This PR formats Date, DateTime, and Time using the ISO 8601 standard and allows dates to be used in queries.

fredjean added some commits Aug 23, 2012

Upgrading bundler to 1.1.x
Also making sure that bundle install works on 1.9
Formatting date and time values when building SOQL queries
The dates were formatted using their to_s methods. This introduced white
spaces in the values and generated invalid queries. This uses the ISO 8601
format, which is accepted by SF.com.

@jpr5 @cloudcrowd Anyone looking at this? This will allow dates and date times to be used in queries, which is a big gap in the current implementation.

Thanks!

Owner

jpr5 commented Sep 26, 2012

@fredjean Thanks for the patch- I'll test this later today and roll a new gem if there's no problems.

Separately, shouldn't the gem for Ruby 1.9(.3) be 'debugger'? I remember 'ruby-debug19' was necessary with 1.8.7 < x < 1.9.3, but last time I tried 'ruby-debug19' on 1.9.3 it failed.

@ghost ghost assigned jpr5 Sep 26, 2012

I think that the current one is indeed 'debugger'. I have switched to Pry for debugging though...

Owner

jpr5 commented Oct 1, 2012

Merged these in, rolled and pushed 1.0.6 out to rubygems. Thanks for the patches!

@jpr5 jpr5 closed this Oct 1, 2012

fredjean commented Oct 2, 2012

Excellent! Thank you (and you are welcome)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment