Date Value Formatting #5
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also making sure that bundle install works on 1.9
The dates were formatted using their to_s methods. This introduced white spaces in the values and generated invalid queries. This uses the ISO 8601 format, which is accepted by SF.com.
|
@jpr5 @cloudcrowd Anyone looking at this? This will allow dates and date times to be used in queries, which is a big gap in the current implementation. Thanks! |
|
@fredjean Thanks for the patch- I'll test this later today and roll a new gem if there's no problems. Separately, shouldn't the gem for Ruby 1.9(.3) be 'debugger'? I remember 'ruby-debug19' was necessary with 1.8.7 < x < 1.9.3, but last time I tried 'ruby-debug19' on 1.9.3 it failed. |
ghost
assigned
|
I think that the current one is indeed 'debugger'. I have switched to Pry for debugging though... |
|
Merged these in, rolled and pushed 1.0.6 out to rubygems. Thanks for the patches! |
|
Excellent! Thank you (and you are welcome) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR formats
Date,DateTime, andTimeusing the ISO 8601 standard and allows dates to be used in queries.