Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ability to create Iceberg V1 and V2 tables #149

Merged
merged 3 commits into from Mar 27, 2023

Conversation

hpasumarthi
Copy link
Contributor

@hpasumarthi hpasumarthi commented Mar 14, 2023

Describe your changes

Hello Team,
We have added the following code changes

  • ability to create iceberg table e.g stored by iceberg will be inserted if is_iceberg is set to true
  • By passing the tbl_properties we can choose V1 or V2 iceberg table tbl_properties="('format-version'='2')"

Internal Jira ticket number or external issue link

https://jira.cloudera.com/browse/DBT-671

Testing procedure/screenshots(if appropriate):

Checklist before requesting a review

  • [Yes ] I have performed a self-review of my code
  • [ Notsure ] I have formatted my added/modified code to follow pep-8 standards
  • [ Yes ] I have checked suggestions from python linter to make sure code is of good quality.

@hpasumarthi
Copy link
Contributor Author

Here are the screenshots of our testing
-- We have created a iceberg V2 table with a set configurations and the table show create output confirms that the iceberg table has been create.

Screenshot 2023-03-14 at 09 38 10

Screenshot 2023-03-14 at 09 38 54

Screenshot 2023-03-14 at 09 39 08

Screenshot 2023-03-14 at 09 39 16

Copy link
Contributor

@tovganesh tovganesh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me

Copy link
Collaborator

@vamshikolanu vamshikolanu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good to me.

@vamshikolanu vamshikolanu merged commit d0ef6ef into cloudera:master Mar 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants