Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DBT-684: Add functional tests for iceberg #157

Merged
merged 6 commits into from Apr 27, 2023
Merged

Conversation

vamshikolanu
Copy link
Collaborator

@vamshikolanu vamshikolanu commented Apr 25, 2023

Describe your changes

Adding function tests for iceberg table format that was landed as part of #149.
Please note that for iceberg check_relations_equal util is not working. Hence removing this check as part of unit tests.
Here is the upstream impala ticket for the same: https://issues.apache.org/jira/browse/IMPALA-12097

DBT ticket to include check_relations_equal util for iceberg unit tests: https://jira.cloudera.com/browse/DBT-685

Internal Jira ticket number or external issue link

https://jira.cloudera.com/browse/DBT-684

Testing procedure/screenshots(if appropriate):

https://gist.github.com/vamshikolanu/f367a790e0e30d47d4e69c97f754a477

Checklist before requesting a review

  • I have performed a self-review of my code
  • I have formatted my added/modified code to follow pep-8 standards
  • I have checked suggestions from python linter to make sure code is of good quality.

tests/functional/adapter/test_formats.py Outdated Show resolved Hide resolved
tests/functional/adapter/test_formats.py Outdated Show resolved Hide resolved
tests/functional/adapter/test_formats.py Outdated Show resolved Hide resolved
Copy link
Collaborator

@niteshy niteshy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@vamshikolanu vamshikolanu merged commit 8c2abde into master Apr 27, 2023
@niteshy niteshy deleted the iceberg_changes branch May 1, 2023 21:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants