Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[core] getting complete snippet for close_statement call #2777

Merged
merged 1 commit into from
Apr 1, 2022
Merged

[core] getting complete snippet for close_statement call #2777

merged 1 commit into from
Apr 1, 2022

Conversation

agl29
Copy link
Collaborator

@agl29 agl29 commented Apr 1, 2022

What changes were proposed in this pull request?

  • getting complete snippet for close_statement call (for the editor call)

How was this patch tested?

  • impala UI
  • Hue api response (manually)

Harshg999
Harshg999 approved these changes Apr 1, 2022
View reviewed changes
Copy link
Collaborator

@Harshg999 Harshg999 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@agl29 agl29 merged commit 0128288 into master Apr 1, 2022
@agl29 agl29 deleted the close_statement2 branch April 1, 2022 12:15
agl29 added a commit that referenced this pull request Jul 24, 2023
@agl29 @wing2fly
DWX-10330 [core] getting complete snippet for close_statement call (#…
022d4ec 
…2777)

(cherry picked from commit 0128288)
(cherry picked from commit db1e1b2)
Change-Id: I4378c1c4d4dcd7200cc95d8c038eb9f35cdba8d6
(cherry picked from commit 21bf12f)
@idzikovsky
Copy link
Contributor

Guys, it seems like this fix has broken more that it solved.
Editor UI works, but Notebook UI is almost not usable at all.
I don't get any output for Spark snippets (or any snippets that is not SQL) in unsaved notebooks.
And in saved notebooks I'm able to see an output only for snippets of the type that matches the type of the first snippet.

And I'm observing this on both Hue 4.11 and on Hue built from the master.

@bjornalm
Copy link
Collaborator

bjornalm commented Oct 2, 2023

Hi @idzikovsky thanks for reporting. Can you file an issue following our issue template and we will take a look?

@idzikovsky idzikovsky mentioned this pull request Oct 6, 2023
Closed
1 task
@idzikovsky
Copy link
Contributor

@bjornalm sure:
#3491

athithyaaselvam pushed a commit that referenced this pull request Mar 14, 2024
@agl29 @wing2fly
DWX-10330 [core] getting complete snippet for close_statement call (#…
21bf12f 
…2777)

(cherry picked from commit 0128288)
(cherry picked from commit db1e1b2)
Change-Id: I4378c1c4d4dcd7200cc95d8c038eb9f35cdba8d6
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Harshg999 Harshg999 Harshg999 approved these changes

@JohanAhlen JohanAhlen Awaiting requested review from JohanAhlen

@wing2fly wing2fly Awaiting requested review from wing2fly

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@agl29 @idzikovsky @bjornalm @Harshg999