Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add codeowners file #1038

Merged
merged 1 commit into from
Apr 22, 2024
Merged

chore: add codeowners file #1038

merged 1 commit into from
Apr 22, 2024

Conversation

embano1
Copy link
Member

@embano1 embano1 commented Apr 22, 2024

Add @cloudevents/sdk-go-maintainers as CODEOWNERS (will be used in branch protection to request reviews).

Closes: #1037

@@ -0,0 +1,2 @@
* @cloudevents/maintainers
Copy link
Contributor

@duglin duglin Apr 22, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think we want all CE maintainers to have write access, do we?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yup, that's what I wanted to discuss. will change 👍

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I mean... do we really trust @deissnerk ? :-)

Closes: cloudevents#1037
Signed-off-by: Michael Gasch <15986659+embano1@users.noreply.github.com>
@embano1 embano1 merged commit 9a61fca into cloudevents:main Apr 22, 2024
9 checks passed
@embano1 embano1 deleted the issue-1037 branch April 22, 2024 14:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create CODE OWNERS file for reviewers
2 participants