Add EventResponse for send/receive. #42

n3wscott · 2019-03-05T17:16:28Z

This PR enables control over response codes for a transport (transport dependent). For HTTP this means letting the receiver control which HTTP status code is returned, as well as a response cloudevents.Event object. That response object will be passed through the client's defaulter chain if it the client is used to Send/Receive events ✨.

The signature of client.Receive has changed significantly, but in a followup PR I will reduce its complexity once again, and the README will not be wrong with the following:

func Receive(event cloudevents.Event) {
	// do something with event.Context and event.Data (via event.DataAs(foo)
}

Until then, I want to leave the README in a broken state, because the samples do work and after the next PR, the README will be correct as well.

Fixes: #31

Signed-off-by: Scott Nichols nicholss@google.com

…alue on recieve. Signed-off-by: Scott Nichols <nicholss@google.com>

Signed-off-by: Scott Nichols <nicholss@google.com>

n3wscott · 2019-03-06T21:18:34Z

Note: This is dependent on #45

Signed-off-by: Scott Nichols <nicholss@google.com>

…the defaulter chain to the outbound message. Signed-off-by: Scott Nichols <nicholss@google.com>

Signed-off-by: Scott Nichols <nicholss@google.com>

n3wscott · 2019-03-07T21:36:51Z

HTTP Receive Sample now outputs like:

----------------------------
Got Event Context: {CloudEventsVersion:0.1 EventID:de2128dc-3802-43e0-8cde-e8f5b6d7b7a4 EventTime:2019-03-07T21:31:07.350717Z EventType:com.cloudevents.sample.sent EventTypeVersion:<nil> SchemaURL: ContentType:0xc0001a2040 Source:{URL:{Scheme:https Opaque: User: Host:github.com Path:/cloudevents/sdk-go/cmd/samples/sender RawPath: ForceQuery:false RawQuery: Fragment:}} Extensions:map[]}
Got Data: &{Sequence:12 Message:Hello, Binary Encoding v0.1!}
Got Transport Context: {URI:/interesting/ Host:localhost:8080 Method:POST}
----------------------------

n3wscott · 2019-03-07T21:40:18Z

cmd/samples/http/receiver/main.go

 	fmt.Printf("Got Event Context: %+v\n", event.Context)
 	data := &Example{}
 	if err := event.DataAs(data); err != nil {
 		fmt.Printf("Got Data Error: %s\n", err.Error())
 	}
 	fmt.Printf("Got Data: %+v\n", data)
+
+	fmt.Printf("Got Transport Context: %+v\n", http.TransportContextFrom(ctx))


look at this @Harwayne ^^

That seems to include the HTTP host, path, and method. Nifty.

n3wscott · 2019-03-07T21:41:34Z

cmd/samples/http/responder/main.go

+		cehttp.WithPort(env.Port),
+		cehttp.WithPath(env.Path),
+		client.WithUUIDs(),
+		client.WithTimeNow(),


This is REALLY subtle and awesome. I am setting client options on the http client wrapper, and using those event defaulters to default values on the response event. 💯

n3wscott · 2019-03-07T21:42:59Z

pkg/cloudevents/client/client.go

+// Receive is called from from the transport on event delivery.
+func (c *ceClient) Receive(ctx context.Context, event cloudevents.Event, resp *cloudevents.EventResponse) error {
+	if c.receive != nil {
+		err := c.receive(ctx, event, resp)


client.receive should be mappable to an event type or other interesting filtering. Look into this.

n3wscott · 2019-03-07T21:44:07Z

pkg/cloudevents/client/client.go

+				*resp.Event = fn(*resp.Event)
+			}
+			// Validate the event conforms to the CloudEvents Spec.
+			if err := resp.Event.Validate(); err != nil {


AND!!! outbound events are validated.

n3wscott · 2019-03-07T21:45:26Z

pkg/cloudevents/transport/http/transport.go

 			}
 			defer resp.Body.Close()

+			body, _ := ioutil.ReadAll(resp.Body)


This is gathering the response and smashing it into an event if it can.

Scott Nichols added 9 commits March 4, 2019 15:41

first pass at adding responses from send and controlling the return v…

9c7884a

…alue on recieve. Signed-off-by: Scott Nichols <nicholss@google.com>

cleanup and add context target.

56fb009

Signed-off-by: Scott Nichols <nicholss@google.com>

adding transport context to event. it turns out we need this.

d1f3656

Signed-off-by: Scott Nichols <nicholss@google.com>

Adding client.StopReceiver.

6f6a2b9

Signed-off-by: Scott Nichols <nicholss@google.com>

adding client test to receive to test new stop.

354860e

Signed-off-by: Scott Nichols <nicholss@google.com>

adding testing for client stop. needed a way to pass back the real port.

9752370

Signed-off-by: Scott Nichols <nicholss@google.com>

testing the helper function for new http recv now too.

e688b65

Signed-off-by: Scott Nichols <nicholss@google.com>

fix the sig change on the samples.

749d036

Signed-off-by: Scott Nichols <nicholss@google.com>

Merge branch 'add-client-stop' into complex_receiver

6af6739

Signed-off-by: Scott Nichols <nicholss@google.com>

Scott Nichols added 3 commits March 7, 2019 10:40

Merge branch 'master' into complex_receiver

ef5cf09

Adding EventResponse.

4eaae43

Signed-off-by: Scott Nichols <nicholss@google.com>

Because the client now has access to the response, it can also apply …

79dbe6e

…the defaulter chain to the outbound message. Signed-off-by: Scott Nichols <nicholss@google.com>

n3wscott changed the title ~~[WIP] Enable error responses, responses for send/receive.~~ Add EventResponse for send/receive. Mar 7, 2019

wire in transport context.

9891983

Signed-off-by: Scott Nichols <nicholss@google.com>

n3wscott marked this pull request as ready for review March 7, 2019 21:37

n3wscott requested a review from markpeek March 7, 2019 21:39

n3wscott commented Mar 7, 2019

View reviewed changes

n3wscott mentioned this pull request Mar 7, 2019

client.receive should be mappable to an event type or other interesting filtering. Look into this. #66

Closed

n3wscott commented Mar 7, 2019

View reviewed changes

markpeek merged commit 76d94e4 into cloudevents:master Mar 8, 2019

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add EventResponse for send/receive. #42

Add EventResponse for send/receive. #42

n3wscott commented Mar 5, 2019 •

edited

Loading

n3wscott commented Mar 6, 2019

n3wscott commented Mar 7, 2019

n3wscott Mar 7, 2019

Harwayne Mar 7, 2019

n3wscott Mar 7, 2019

n3wscott Mar 7, 2019

n3wscott Mar 7, 2019

n3wscott Mar 7, 2019

Add EventResponse for send/receive. #42

Add EventResponse for send/receive. #42

Conversation

n3wscott commented Mar 5, 2019 • edited Loading

n3wscott commented Mar 6, 2019

n3wscott commented Mar 7, 2019

n3wscott Mar 7, 2019

Choose a reason for hiding this comment

Harwayne Mar 7, 2019

Choose a reason for hiding this comment

n3wscott Mar 7, 2019

Choose a reason for hiding this comment

n3wscott Mar 7, 2019

Choose a reason for hiding this comment

n3wscott Mar 7, 2019

Choose a reason for hiding this comment

n3wscott Mar 7, 2019

Choose a reason for hiding this comment

n3wscott commented Mar 5, 2019 •

edited

Loading