Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CloudEvent.toString() should not include null attributes #326

Closed
wlaforest opened this issue Dec 11, 2020 · 2 comments · Fixed by #376
Closed

CloudEvent.toString() should not include null attributes #326

wlaforest opened this issue Dec 11, 2020 · 2 comments · Fixed by #376
Assignees
@slinkydeveloper
Labels
bug Something isn't working good first issue Good for newcomers
Milestone
2.1

Comments

@wlaforest
Copy link

I have only checked io.cloudevents.core.v1.CloudEventV1 but rather than concatenation null values for optional attributes they should be omitted. I am open to fixing this and doing a pull request if this is preferred.. potentially its already fixed in a branch? Thank you everyone for the work.
@slinkydeveloper
Copy link
Member

Hi, you can go ahead and open a PR for it, thanks for spotting it!

@slinkydeveloper slinkydeveloper added the bug Something isn't working label Dec 11, 2020
@slinkydeveloper slinkydeveloper added this to the 2.0.0 milestone Dec 11, 2020
@slinkydeveloper slinkydeveloper added the good first issue Good for newcomers label Jan 27, 2021
@slinkydeveloper slinkydeveloper modified the milestones: 2.0.0, 2.0.1 Feb 15, 2021
@slinkydeveloper slinkydeveloper modified the milestones: 2.0.1, 2.1 Apr 27, 2021
@slinkydeveloper slinkydeveloper self-assigned this Apr 28, 2021
slinkydeveloper added a commit to slinkydeveloper/sdk-java that referenced this issue Apr 28, 2021
@slinkydeveloper
Fix cloudevents#326
b5a2736 
Signed-off-by: Francesco Guardiani <francescoguard@gmail.com>
@slinkydeveloper slinkydeveloper mentioned this issue Apr 28, 2021
Merged
slinkydeveloper added a commit that referenced this issue Apr 28, 2021
@slinkydeveloper
Fix #326 (#376)
78355bb 
Signed-off-by: Francesco Guardiani <francescoguard@gmail.com>
@edmondop
Copy link

@slinkydeveloper hello you. Can you explain why the CloudEvent constructor is public rather than being package protected?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@slinkydeveloper slinkydeveloper

Labels
bug Something isn't working good first issue Good for newcomers
Projects
None yet
Milestone
2.1
Development

Successfully merging a pull request may close this issue.

CloudEvent.toString() does not include null attributes slinkydeveloper/sdk-java
3 participants
@edmondop @wlaforest @slinkydeveloper