Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CloudEvent.toString() does not include null attributes #376

Merged
merged 1 commit into from
Apr 28, 2021
Merged

CloudEvent.toString() does not include null attributes #376

merged 1 commit into from
Apr 28, 2021

Conversation

slinkydeveloper
Copy link
Member

Fix #326

Signed-off-by: Francesco Guardiani francescoguard@gmail.com

@slinkydeveloper
Fix cloudevents#326
b5a2736 
Signed-off-by: Francesco Guardiani <francescoguard@gmail.com>
@slinkydeveloper slinkydeveloper added the bug Something isn't working label Apr 28, 2021
@slinkydeveloper slinkydeveloper added this to the 2.1 milestone Apr 28, 2021
matzew
matzew approved these changes Apr 28, 2021
View reviewed changes
Copy link
Member

@matzew matzew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@slinkydeveloper slinkydeveloper merged commit 78355bb into cloudevents:master Apr 28, 2021
@slinkydeveloper slinkydeveloper deleted the issues/326 branch April 28, 2021 13:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matzew matzew matzew approved these changes

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
2.1
Development

Successfully merging this pull request may close these issues.

CloudEvent.toString() should not include null attributes
2 participants
@slinkydeveloper @matzew