-
Notifications
You must be signed in to change notification settings - Fork 159
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor to Facilitate Decoupling from Concrete Implementations of EventFormat #539
Refactor to Facilitate Decoupling from Concrete Implementations of EventFormat #539
Conversation
8f82cdb
to
02b5bd1
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks like you need to sign your 'git commit' to get the build to run.
I do like how this cleans up the dependencies, may need to tweak the documentation on the ContentType to make it clear it's only enumerating the types defined by the various CloudEvent formats.
And it looks like you 'pushed' while I was commenting :-) |
Signed-off-by: Randi Sheaffer-Klass <97033958+skepticoitusInteruptus@users.noreply.github.com>
Signed-off-by: Randi Sheaffer-Klass <97033958+skepticoitusInteruptus@users.noreply.github.com>
Yeah. I didn't intend to push so many commits. I tried (in vain) to rebase all but one of them away. But I ended up with even more than I started out with. I suck at |
formats/json-jackson/src/main/java/io/cloudevents/jackson/JsonFormat.java
Outdated
Show resolved
Hide resolved
formats/json-jackson/src/main/java/io/cloudevents/jackson/JsonFormat.java
Show resolved
Hide resolved
Signed-off-by: Randi Sheaffer-Klass <97033958+skepticoitusInteruptus@users.noreply.github.com>
Signed-off-by: Randi Sheaffer-Klass <97033958+skepticoitusInteruptus@users.noreply.github.com>
53e6081
to
e1dbe9c
Compare
Signed-off-by: Randi Sheaffer-Klass <97033958+skepticoitusInteruptus@users.noreply.github.com>
formats/json-jackson/src/main/java/io/cloudevents/jackson/JsonFormat.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Randi Sheaffer-Klass <97033958+skepticoitusInteruptus@users.noreply.github.com>
formats/json-jackson/src/main/java/io/cloudevents/jackson/JsonFormat.java
Outdated
Show resolved
Hide resolved
core/src/main/java/io/cloudevents/core/provider/EventFormatProvider.java
Outdated
Show resolved
Hide resolved
formats/json-jackson/src/main/java/io/cloudevents/jackson/JsonFormat.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Randi Sheaffer-Klass <97033958+skepticoitusInteruptus@users.noreply.github.com>
Signed-off-by: Randi Sheaffer-Klass <97033958+skepticoitusInteruptus@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
LGTM
…entFormat (cloudevents#539) - Introduce ContentType enum - Resolve formats by using the ContentType enum Signed-off-by: Randi Sheaffer-Klass <97033958+skepticoitusInteruptus@users.noreply.github.com> Signed-off-by: Alex Collins <alex_collins@intuit.com>
Closes #537
Example Usage of Proposed Refactor