Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HTTP binding for binary format #18

Closed
ghost opened this issue Jun 11, 2019 · 5 comments
Closed

HTTP binding for binary format #18

ghost opened this issue Jun 11, 2019 · 5 comments
Labels
good first issue Good for newcomers type/bug Something isn't working

Comments

@ghost
Copy link

ghost commented Jun 11, 2019

The HTTP binding for binary formatted data currently does not follow the cloudevents/spec:

  1. The event type, time, and schema url should not be required
  2. the content-type should be json, but not cloudevents-json

Additionally, the config object should be copied because creating multiple bindings with the same config will override the content-type.

Fixed in issue #14.

@fabiojose fabiojose added type/bug Something isn't working good first issue Good for newcomers labels Jun 12, 2019
@fabiojose
Copy link
Contributor

Release in version 0.2.2

@ghost
Copy link
Author

ghost commented Jun 25, 2019

@fabiojose Tried to use the updated version and I noticed my changes for emitter_binary_0_2 didn't get merged in properly... The optional / required fields do not follow the spec but remain as they used to be.

@fabiojose
Copy link
Contributor

Oh boy! I will check what gonna wrong!

fabiojose added a commit that referenced this issue Jun 30, 2019
Signed-off-by: Fabio José <fabiojose@gmail.com>
@fabiojose
Copy link
Contributor

@ghost
Copy link
Author

ghost commented Jul 2, 2019

Thanks, it works :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers type/bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant