Recommend dropping support for 0.2 #61
Comments
|
I agree in dropping 0.2 (and I support dropping 0.3). |
|
+1 in dropping support for 0.2 |
|
@grant currently it is recommended that adapters continue to support v0.3. See: https://github.com/cloudevents/spec/blob/master/SDK.md#contribution-acceptance |
I propose we follow the versioning of the most mature CE SDK, Go, and support v1 and v2. However, this library needs a bit of work before then. |
|
+1 |
lance
added a commit
to lance/sdk-javascript
that referenced
this issue
Apr 27, 2020
This commit removes support for the v0.2 specification. It also removes the `contenttype` attribute from the `CloudEvent` object. While the HTTP protocol binding specifies that in binary mode, the `datacontenttype` attribute should map to the HTTP Content-Type header, that doesn't mean that the `CloudEvent` object should have a `contenttype` property. Fixes: cloudevents#61 Fixes: cloudevents#66 Signed-off-by: Lance Ball <lball@redhat.com>
lance
added a commit
to lance/sdk-javascript
that referenced
this issue
Apr 28, 2020
This commit removes support for the v0.2 specification. It also removes the `contenttype` attribute from the `CloudEvent` object. While the HTTP protocol binding specifies that in binary mode, the `datacontenttype` attribute should map to the HTTP Content-Type header, that doesn't mean that the `CloudEvent` object should have a `contenttype` property. Fixes: cloudevents#61 Fixes: cloudevents#66 Signed-off-by: Lance Ball <lball@redhat.com>
fabiojose
pushed a commit
that referenced
this issue
Apr 28, 2020
This commit removes support for the v0.2 specification. It also removes the `contenttype` attribute from the `CloudEvent` object. While the HTTP protocol binding specifies that in binary mode, the `datacontenttype` attribute should map to the HTTP Content-Type header, that doesn't mean that the `CloudEvent` object should have a `contenttype` property. Fixes: #61 Fixes: #66 Signed-off-by: Lance Ball <lball@redhat.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
In the SDK requirements documentation, it says "Each SDK supports the latest(N), and N-1, major releases of the CloudEvent spec", with a special case being 1.0 as latest with 0.3 recommended support.
Ultimately, dropping support for 0.2 should make maintenance simpler. From npm download numbers, I guess it's hard to tease out how many are still on 0.2, but this seems reasonable.
I wonder also what the versioning strategy is. Is the npm module is versioned independently from the spec version? It seems like it must be - at least for minor and patch levels.
The text was updated successfully, but these errors were encountered: