Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make SDK compliant with CloudEvents SDK spec #2

Merged
merged 1 commit into from
Dec 8, 2018
Merged

Conversation

denismakogon
Copy link
Member

SDK spec was merged.
Now we need to make all SDK compliant with it.
So, as for now, "upstream" becomes "v02" and the rest of API methods are now compliant.

Signed-off-by: Denis Makogon <lildee1991@gmail.com>
WithEventType("cloudevent.greet.you")
SetContentType("application/json").
SetData('{"name":"john"}').
SetEventID("my-id").
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

any reason this isn't just SetID to align with the property name change? Same for Time and Type below.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That’s what’s in SDK spec. Verbose API is a better option here, less things seem to be ambiguous.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ah ok

@duglin
Copy link
Contributor

duglin commented Dec 8, 2018

I don't really know python but it seems ok to me - for what that's worth :-)

@denismakogon
Copy link
Member Author

Just need a formal approval to release a new version of an SDK.

@duglin
Copy link
Contributor

duglin commented Dec 8, 2018

LGTM

@denismakogon denismakogon merged commit 67e3525 into master Dec 8, 2018
@denismakogon denismakogon deleted the sdk-spec branch December 8, 2018 22:55
@denismakogon denismakogon mentioned this pull request Dec 8, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants