Make SDK compliant with CloudEvents SDK spec #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Denis Makogon <lildee1991@gmail.com>
denismakogon
force-pushed
the
sdk-spec
branch
from
08aa0c0
to
22b8b89
Compare
duglin
reviewed
Dec 8, 2018
| WithEventType("cloudevent.greet.you") | ||
| SetContentType("application/json"). | ||
| SetData('{"name":"john"}'). | ||
| SetEventID("my-id"). |
There was a problem hiding this comment.
any reason this isn't just SetID to align with the property name change? Same for Time and Type below.
There was a problem hiding this comment.
That’s what’s in SDK spec. Verbose API is a better option here, less things seem to be ambiguous.
|
I don't really know python but it seems ok to me - for what that's worth :-) |
|
Just need a formal approval to release a new version of an SDK. |
|
LGTM |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SDK spec was merged.
Now we need to make all SDK compliant with it.
So, as for now, "upstream" becomes "v02" and the rest of API methods are now compliant.