Batch Event implementation for reqwest bindings #200
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added `events(Vec<Event>)` to `RequestBuilderExt` to provide a batched set of Events to send to an HTTP endpoint, and `into_events() -> Result<Vec<Event>>` to ResponseExt to parse a batched Event response. I deliberately kept things simple, as I thought this would be a good place to start with Batch support throughout the SDK, and the implementation was simple enough, that there didn't seem to be much opportunity for reusable libraries across the SDK. That could be changed as more Batch support is provided across the SDK, and opportunities for code reuse present themselves. Signed-off-by: Mark Mandel <markmandel@google.com>
markmandel
force-pushed
the
reqwest/batch-send
branch
from
d129b33
to
466102e
Compare
|
Looks good, thank you! And I agree we can defer adding the batching behavior to the message [de]serializers. |
|
Awesome! That just made my day 😄 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added
events(Vec<Event>)toRequestBuilderExtto provide a batched set of Events to send to an HTTP endpoint, andinto_events() -> Result<Vec<Event>>toResponseExtto parse a batched Event response.I deliberately kept things simple, as I thought this would be a good place to start with Batch support throughout the SDK, and the implementation was simple enough, that there didn't seem to be much opportunity for reusable libraries across the SDK. That could be changed as more Batch support is provided across the SDK, and opportunities for code reuse present themselves.