Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

initial spec #1

Merged
merged 1 commit into from
Dec 14, 2017
Merged

initial spec #1

merged 1 commit into from
Dec 14, 2017

Conversation

duglin
Copy link
Collaborator

@duglin duglin commented Dec 11, 2017

Signed-off-by: Doug Davis dug@us.ibm.com
Signed-off-by: Austen Collins austen@serverless.com

Copy link
Contributor

@austencollins austencollins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other than the new properties that were added in by a single contributor which need to be discussed first, these look fine.

spec.md Outdated
* Required
* Unique per producer

### correlation-id
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@duglin Could we move this to the Context Attributes Backlog. This was suggested in the Google doc by a contributor, but wasn't agreed to by anyone else. We need to discuss and review new properties before adding them in.

* Constraints:
* Optional

### causation-id
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@duglin Could we move this to the Context Attributes Backlog. This was suggested in the Google doc by a contributor, but wasn't agreed to by anyone else. We need to discuss and review new properties before adding them in.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No idea why this comment didn't go away when I moved the entry, but I did move it as you can see.

@duglin
Copy link
Collaborator Author

duglin commented Dec 12, 2017

@ac360 can you add a comment saying that you agree with the edit and are "signing off" on it - in essence signing a DCO, just so we transfer right to the group?

@duglin duglin force-pushed the initalSpec branch 2 times, most recently from 05776cb to c126153 Compare December 12, 2017 21:30
Signed-off-by: Doug Davis <dug@us.ibm.com>
Signed-off-by: Austen Collins <austen@serverless.com>
@austencollins
Copy link
Contributor

These edits look good to me.

@duglin duglin merged commit 18aad14 into cloudevents:master Dec 14, 2017
@duglin duglin deleted the initalSpec branch December 14, 2017 16:41
@ultrasaurus ultrasaurus mentioned this pull request Mar 20, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants