-
Notifications
You must be signed in to change notification settings - Fork 581
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
initial spec #1
initial spec #1
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Other than the new properties that were added in by a single contributor which need to be discussed first, these look fine.
spec.md
Outdated
* Required | ||
* Unique per producer | ||
|
||
### correlation-id |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@duglin Could we move this to the Context Attributes Backlog
. This was suggested in the Google doc by a contributor, but wasn't agreed to by anyone else. We need to discuss and review new properties before adding them in.
* Constraints: | ||
* Optional | ||
|
||
### causation-id |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@duglin Could we move this to the Context Attributes Backlog
. This was suggested in the Google doc by a contributor, but wasn't agreed to by anyone else. We need to discuss and review new properties before adding them in.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No idea why this comment didn't go away when I moved the entry, but I did move it as you can see.
@ac360 can you add a comment saying that you agree with the edit and are "signing off" on it - in essence signing a DCO, just so we transfer right to the group? |
05776cb
to
c126153
Compare
Signed-off-by: Doug Davis <dug@us.ibm.com> Signed-off-by: Austen Collins <austen@serverless.com>
These edits look good to me. |
Signed-off-by: Doug Davis dug@us.ibm.com
Signed-off-by: Austen Collins austen@serverless.com