-
Notifications
You must be signed in to change notification settings - Fork 582
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rename attributes 'resource*' to 'source*' #30
Conversation
Have few somewhat related questions:
|
@lfourie you'll need to sign your commit |
@sslavic those are good questions. Can you open a separate issue to answer those since this one is just a syntax/word change and if it is merged quickly I don't want to forget to have a discussion about your questions? |
Created #41 |
@sslavic thanks! |
@lfourie can you please sign your commit - I think we might be able to resolve this one quickly on the next call but we can't merge it unless its signed. |
LGTM once signed |
@lfourie why close this one? It hasn't been merged. As @duglin suggested, before it can be merged, commit needs to be amended with sign-off info, as per contributing guidelines https://github.com/cloudevents/spec/blob/master/CONTRIBUTING.md#sign-your-work |
@lfourie I reopened this one and fixed your DCO |
21cad3f
to
f8a4108
Compare
Signed-off-by: lfourie <louis.fourie@huawei.com>
LGTM |
I like the change from resource => source. I think it is a lot clearer than original naming! |
LGTM |
1 similar comment
LGTM |
Approved on Feb 1st call. |
Closes #38