Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce set_async_get_session_callback #174

Merged
merged 5 commits into from
Oct 25, 2023

Conversation

nox
Copy link
Collaborator

@nox nox commented Oct 12, 2023

The signature of the sync callback required a breaking change.

@ghedo
Copy link
Member

ghedo commented Oct 23, 2023

Ideally there should be a test, like we have for the other async callbacks.

@nox nox force-pushed the async-set-get-session-callback branch 4 times, most recently from 2ffe1fe to a3c51ef Compare October 24, 2023 17:45
@nox nox force-pushed the async-set-get-session-callback branch from a3c51ef to 3162782 Compare October 24, 2023 17:52
@ghedo ghedo merged commit 1ca7f76 into cloudflare:master Oct 25, 2023
21 checks passed
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants