Upgrade ring to 0.16 #115
Merged
Upgrade ring to 0.16 #115
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The API for SealingKey and OpeningKey changed to have these structs manage their own nonces. Instead we switch to LessSafeKey so that we can continue to manually manage nonce values.
vkrasnov
reviewed
Jan 25, 2020
| ) | ||
| .unwrap() | ||
| self.sender | ||
| .seal_in_place_separate_tag( |
There was a problem hiding this comment.
I think using seal_in_place_append_tag is the more appropriate function here?
There was a problem hiding this comment.
We can't use it, the destination buffer is a slice so doesn't implement Extend.
vkrasnov
approved these changes
Jan 28, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The API for SealingKey and OpeningKey changed to have these structs
manage their own nonces. Instead we switch to LessSafeKey so that we can
continue to manually manage nonce values.
Benchmark results before and after are well within the expected variance, at least on my computer.