update Dockerfile.minimal to use alpine 3.4 (and go 1.6) #669
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aboyett
force-pushed
the
fix-minimal-docker
branch
from
056eeca
to
0674cc7
Compare
aboyett
changed the title
|
whoops, slight typo in the commit and PR title. updated! |
Current coverage is 58.36% (diff: 100%)@@ master #669 diff @@
==========================================
Files 74 74
Lines 6420 6420
Methods 0 0
Messages 0 0
Branches 0 0
==========================================
Hits 3747 3747
Misses 2313 2313
Partials 360 360
|
|
This would explain why the automated Dockerfile.minimal builds have been failing. 👍 Though, I'm a bit disappointed that |
lziest
approved these changes
Sep 30, 2016
|
@jacobhaven Alpine Linux has Go 1.7.1 in their development branch (edge.) https://pkgs.alpinelinux.org/packages?name=go |
kisom
approved these changes
Oct 3, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The alpine-based minimal docker image has been broken since 0d7ae8e.
That commit removed Godep-based dependency management favor of go
1.5/1.6 vendoring. This commit moves the base alpine image forward to
3.4 which includes go 1.6.3. The resulting image of 0d7ae8e^ grows from
66 MB to 73 MB.