-
Notifications
You must be signed in to change notification settings - Fork 137
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add go 1.16 version. #215
Add go 1.16 version. #215
Conversation
todo; To investigate clobbered registers in dillithium assembler code. |
It's an issue with avo: mmcloughlin/avo#156 |
I also have it happening in kyber:
The
We are using the x/sys one, but it might be bumped down there too: golang/go@6b66b59#diff-52c997d62192731381cdec487ea0eb77390c9ea5941e4d3ac4c9109c272417f6 @bwesterb bwesterb |
Sort of did something around it here: claucece/go-exp@de5ce64 following https://go-review.googlesource.com/c/go/+/248260/2/src/internal/bytealg/index_amd64.s |
LGTM ;) Thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Co-authored-by: Christopher Patton <chrispatton@gmail.com>
Adds go1.16 version for testing.