Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix #89 #95

Merged
merged 2 commits into from
Mar 16, 2020
Merged

Fix #89 #95

merged 2 commits into from
Mar 16, 2020

Conversation

bwesterb
Copy link
Member

Upstream issue: golang/go#37644

@bwesterb bwesterb requested a review from armfazh March 11, 2020 11:14
@armfazh armfazh changed the title Temporary solution to #89 waiting on upstream. Temporary solution to #89 waiting on upstream Mar 12, 2020
@armfazh
Copy link
Contributor

armfazh commented Mar 12, 2020

To verify it's working, update file .circleci/config.yml with GOVER: 1.14

    # Coverage job
    cover:
        <<: *coverjob
        environment:
            GOVER: 1.13

and make sure the CI tests the PR.

@bwesterb bwesterb force-pushed the temp-89 branch 2 times, most recently from d1189c2 to 46e2497 Compare March 15, 2020 18:31
@bwesterb bwesterb changed the title Temporary solution to #89 waiting on upstream Fix #89 Mar 15, 2020
@bwesterb
Copy link
Member Author

Upstream chose the fix I predicted.

@bwesterb
Copy link
Member Author

@armfazh It passed.

@codecov-io
Copy link

Codecov Report

Merging #95 into master will not change coverage by %.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #95   +/-   ##
=======================================
  Coverage   77.32%   77.32%           
=======================================
  Files          49       49           
  Lines        4882     4882           
=======================================
  Hits         3775     3775           
  Misses       1070     1070           
  Partials       37       37
Impacted Files Coverage Δ
internal/shake/xor_unaligned.go 82.35% <ø> (ø)

armfazh
armfazh approved these changes Mar 16, 2020
View reviewed changes
Copy link
Contributor

@armfazh armfazh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's keep track the changes on upstream to update CIRCL.

@armfazh armfazh merged commit 6de5c8a into cloudflare:master Mar 16, 2020
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@armfazh armfazh armfazh approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@bwesterb @armfazh @codecov-io