Condition DRNG on type of output. #2
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ignatk
reviewed
Nov 25, 2016
| } | ||
|
|
||
| gen := &KeyGen{rng} | ||
| return gen.GeneratePassword(spec) | ||
| } | ||
|
|
||
| func GetKey(password, realm string, seed []byte, keyType int, allowUnsafe bool) (crypto.PrivateKey, error) { | ||
| rng, err := GetRaw(password, realm, seed, allowUnsafe) | ||
| rng, err := getReader(password, realm+fmt.Sprintf("-key(%v)", keyType), seed, allowUnsafe) |
There was a problem hiding this comment.
I think we should try to map back to a string key type rather than to internal int number here. What if in the future we might want to have alternative implementations in other languages, which may internally interpret key type enum differently?
Maybe somehow reuse https://github.com/cloudflare/gokey/blob/master/cmd/gokey/main.go#L31-L36 or put it lower in the stack, so this function can access defined string literals.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Right now, for example, learning an ECDSA private key for a realm leaks information about passwords/RSA private keys for the same realm.