Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DO Alarms patch #294

Merged
merged 10 commits into from
Jun 28, 2022
Merged

DO Alarms patch #294

merged 10 commits into from
Jun 28, 2022

Conversation

CraigglesO
Copy link
Contributor

@CraigglesO CraigglesO commented Jun 21, 2022 •
edited
Loading

Aims to solve #290 behavior mismatch.

TODO:

  • Check with devs on what proper response to setAlarm(0) is
  • Add new tests

@CraigglesO
Copy link
Contributor Author

@mrbbot - ready for review! 💯 🎊 🇦🇶 🐺 🐶 🔩 👾 🛰️

mrbbot
mrbbot approved these changes Jun 28, 2022
View reviewed changes
Copy link
Contributor

@mrbbot mrbbot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! ✅ A couple minor things, but happy to merge as is. 🎉

packages/durable-objects/src/alarms.ts Outdated Show resolved Hide resolved
packages/durable-objects/src/alarms.ts Outdated Show resolved Hide resolved
@CraigglesO
Copy link
Contributor Author

Should be ready now. 🎊

@mrbbot mrbbot merged commit 5c5b0ad into cloudflare:master Jun 28, 2022
@mrbbot mrbbot mentioned this pull request Jul 2, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mrbbot mrbbot mrbbot approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@CraigglesO @mrbbot