[Miniflare 2] Fix binding of ?N parameters in D1 prepared statements
#544
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`better-sqlite3` expects parameters of the form `?1, ?2, ...` to be
bound as an object of the form `{ 1: params[0], 2: params[1], ...}`.
In #480, we accidentally removed the code that handled this case.
This PR adds it back, and lifts out some common functionality into a
`#prepareAndBind()` function. :)
Thanks @ruslantalpa for spotting the removed code.
Closes #526
Closes cloudflare/workers-sdk#2811
Closes cloudflare/workers-sdk#2887
|
mrbbot
changed the title
?N parameters in D1 prepare statements?N parameters in D1 prepared statements
penalosa
approved these changes
Mar 23, 2023
mrbbot
added a commit
that referenced
this pull request
May 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
better-sqlite3expects parameters of the form?1, ?2, ...to be bound as an object of the form{ 1: params[0], 2: params[1], ...}. In #480, we accidentally removed the code that handled this case. This PR adds it back, and lifts out some common functionality into a#prepareAndBind()function. :)Thanks @ruslantalpa for spotting the removed code.
Closes #504
Closes #526
Closes cloudflare/workers-sdk#2811
Closes cloudflare/workers-sdk#2887