馃悰 BUG: Parameter binding handled differently between local miniflare and cloud #2811
Comments
|
Hey! 馃憢 This is very likely the same issue as cloudflare/miniflare#504. I'll leave this issue open to track upgrading Miniflare to a fixed version. |
mrbbot
added a commit
to cloudflare/miniflare
that referenced
this issue
Mar 22, 2023
`better-sqlite3` expects parameters of the form `?1, ?2, ...` to be
bound as an object of the form `{ 1: params[0], 2: params[1], ...}`.
In #480, we accidentally removed the code that handled this case.
This PR adds it back, and lifts out some common functionality into a
`#prepareAndBind()` function. :)
Thanks @ruslantalpa for spotting the removed code.
Closes #526
Closes cloudflare/workers-sdk#2811
Closes cloudflare/workers-sdk#2887
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Which Cloudflare product(s) does this pertain to?
D1
What version of
Wranglerare you using?2.11.1
What operating system are you using?
Mac
Describe the Bug
TLDR,
ctx.DB.prepare('SELECT ?1').bind(1)produce ErrorError: Error: RangeError: Too many parameter values were providedin local mode but it works in cloud versionRelated issue (since miniflare use better-sqlite3): WiseLibs/better-sqlite3#576
(DB is D1 database)
(command line is:
wrangler dev --local --persist)The text was updated successfully, but these errors were encountered: