Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Miniflare 3] Bump to TypeScript 5 and fix bundled TypeScript output #635

Merged
merged 3 commits into from
Jul 21, 2023
Merged

[Miniflare 3] Bump to TypeScript 5 and fix bundled TypeScript output #635

merged 3 commits into from
Jul 21, 2023

Commits on Jul 21, 2023

  1. Bump to typescript@5.0.4 and @microsoft/api-extractor@7.63.3 

    TypeScript 5 includes lots of goodies, and allows us to remove a
bunch of `@ts-expect-error`s.
    @mrbbot
    mrbbot committed Jul 21, 2023
    Configuration menu
    Copy the full SHA
    4bc1a3d View commit details
    Browse the repository at this point in the history

  2. Set "moduleResolution": "bundler" in tsconfig.json 

    This loosens some resolution rules in accordance with how bundlers
like `esbuild` resolve modules. This also allows us to remove a bunch
of `@ts-expect-error`s.
    @mrbbot
    mrbbot committed Jul 21, 2023
    Configuration menu
    Copy the full SHA
    6507d9e View commit details
    Browse the repository at this point in the history

  3. Remove import cycle in src/plugins/r2 

    This probably wasn't a problem, but generally it's not great to have
cyclic dependencies. For future reference, this was found with
`npx madge --circular --extensions ts packages/miniflare/src`.
    @mrbbot
    mrbbot committed Jul 21, 2023
    Configuration menu
    Copy the full SHA
    23ccf01 View commit details
    Browse the repository at this point in the history