[Miniflare 3] Bump to TypeScript 5 and fix bundled TypeScript output #635
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TypeScript 5 includes lots of goodies, and allows us to remove a bunch of `@ts-expect-error`s.
|
RamIdeas
approved these changes
Jul 21, 2023
penalosa
approved these changes
Jul 21, 2023
This loosens some resolution rules in accordance with how bundlers like `esbuild` resolve modules. This also allows us to remove a bunch of `@ts-expect-error`s.
This probably wasn't a problem, but generally it's not great to have cyclic dependencies. For future reference, this was found with `npx madge --circular --extensions ts packages/miniflare/src`.
mrbbot
force-pushed
the
bcoll/tre-fix-types
branch
from
4a0312a
to
23ccf01
Compare
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR includes a bunch of small changes to fix Miniflare's types. The combination of changes fixes #634. See the commit descriptions for a summary of each. 馃憤