Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Publish Docker image #1

Closed
terinjokes opened this issue Nov 13, 2020 · 13 comments · Fixed by #6
Closed

Publish Docker image #1

terinjokes opened this issue Nov 13, 2020 · 13 comments · Fixed by #6
Assignees

Comments

@terinjokes
Copy link
Contributor

Now that we're open source (🥳), it's time to get an image pushed to Docker Hub, and the deployment manifests updated to match.

@terinjokes terinjokes self-assigned this Nov 13, 2020
@xunholy
Copy link

xunholy commented Nov 14, 2020

Please ensure the docker image is multi-architecture supported. Popular architectures like arm64 often missed, using buildx should make supporting multiple architectures trivial, happy to help if needed.

@terinjokes
Copy link
Contributor Author

The one built right now, that isn't being published anywhere, isn't multi-architecture. However, I agree, and hope to get that working soon.

@xunholy
Copy link

xunholy commented Nov 15, 2020

@terinjokes if you publish the Dockerfile and are happy I can set up some workflows in GHA and get it built and compiled for multi-architecture?

@terinjokes
Copy link
Contributor Author

An update here: I'm still planning on doing this. I'm running into a temporary permissions issue in Docker Hub creating this image and getting credentials to publish from Actions. I hope to have this sorted soon. I'm really sorry for the delay.

@xunholy
Copy link

xunholy commented Dec 4, 2020

All good, can help out if required as I've done this many times, but let me know.

@terinjokes
Copy link
Contributor Author

This isn't a technical problem, unfortunately.

@kg-ops
Copy link

kg-ops commented Dec 8, 2020

Has this image been published yet ?

@terinjokes
Copy link
Contributor Author

Nope. I still do not have the correct permissions in Docker Hub.

@kg-ops
Copy link

kg-ops commented Dec 8, 2020

Is there a way to locally build this image ?

@terinjokes
Copy link
Contributor Author

terinjokes commented Dec 8, 2020

If you have nix installed you can build ./hack/docker.nix. This kicks off the same image build as GitHub Actions.

$ nix build -f ./hack/docker.nix
[11 built, 10 copied (1.5 MiB), 0.4 MiB DL]

$ docker load < result
docker load < result
a630bb07cd03: Loading layer [==================================================>]  1.649MB/1.649MB
14f0fd68d210: Loading layer [==================================================>]    256kB/256kB
7862e9b9223d: Loading layer [==================================================>]  31.63MB/31.63MB
ca397a15dfa0: Loading layer [==================================================>]  573.4kB/573.4kB
542652079767: Loading layer [==================================================>]  112.6kB/112.6kB
255355ea7603: Loading layer [==================================================>]  2.888MB/2.888MB
48ca96316146: Loading layer [==================================================>]  36.37MB/36.37MB
bab8c8268779: Loading layer [==================================================>]  10.24kB/10.24kB
Loaded image: origin-ca-issuer:dvx0mk1aysi6s46r2k3iis92b19klnk1

If you don't have nix installed, I've found the nixpkgs/nix:latest image works well, just make sure to copy the destination of the result symlink before exiting the container.

$ docker -v $(pwd):/opt/work -w /opt/work --rm -it nixpkgs/nix
bash-4.4# nix build -f ./hack/docker.nix
[12 built, 137 copied (951.8 MiB), 225.9 MiB DL]

bash-4.4# cp result image.tar.gz

bash-4.4# exit

$ docker load < image.tar.gz
f04b2eecad2b: Loading layer [==================================================>]   36.4MB/36.4MB
bab8c8268779: Loading layer [==================================================>]  10.24kB/10.24kB
Loaded image: origin-ca-issuer:dvx0mk1aysi6s46r2k3iis92b19klnk1

Obviously, once I have access to pushing to Docker Hub you'll be able to docker pull (or, more relevantly, stick in your YAML) without needing to know or worry about nix at all.


If you don't feel like doing that, this is my local build from rev e06feda: image.tar.gz (21MB)

$ sha256sum image.tar.gz 
ecd572a4402b771e01b7c8865142c737fc0992cd0cca598262878fc309e9c65c  image.tar.gz

@terinjokes terinjokes mentioned this issue Dec 9, 2020
@matthewdaltonfanduel
Copy link

what is blocking this?

@terinjokes
Copy link
Contributor Author

I don't have permission to publish to the Cloudflare Docker Hub organization. I'm working with an internal team to get the permissions sorted out.

terinjokes added a commit that referenced this issue Dec 16, 2020
This changeset updates the docker workflow to build a multi-architecture
(amd64 and arm64) images, and publishes to Docker Hub.

Fixes #1
terinjokes added a commit that referenced this issue Dec 16, 2020
This changeset updates the docker workflow to build a multi-architecture
(amd64 and arm64) images, and publishes to Docker Hub.

Fixes #1
@terinjokes
Copy link
Contributor Author

Sorry for the delay. I've published cloudflare/origin-ca-issuer:v0.5.0 for amd64 and arm64.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants