modify log level of message #205
Conversation
| @@ -25,7 +25,7 @@ use crate::tls::ssl::SslConnector; | |||
| use crate::upstreams::peer::{Peer, ALPN}; | |||
|
|
|||
| use l4::connect as l4_connect; | |||
| use log::{debug, error, warn}; | |||
| use log::{debug, warn}; | |||
There was a problem hiding this comment.
Good that we are removing it, otherwise we would see unnecessary warnings during compilation
| @@ -201,7 +201,7 @@ impl TransportConnector { | |||
| } | |||
| } | |||
| Err(_) => { | |||
| error!("failed to acquire reusable stream"); | |||
| debug!("failed to acquire reusable stream"); | |||
There was a problem hiding this comment.
Is it possible that the connection is present, but we are still unable to acquire the stream due to system level issues? Thinking out loud, if having it as an 'warn' instead, helps for those scenarios
There was a problem hiding this comment.
well, possible other real error scenarios is exactly why I raised it as a question first on pingora's issue board #201. To be fair though, even in the case where it is some system level error, it really should be detected differently and logged differently.
The way it is in its current state probably doesn't serve anyone since you can't tell exactly what happened anyway based on that ERROR log line. All it does now in my application at least is fill logs up with multiple ERRORs even with no actual problems.
|
closing this PR since it looks like there is a code bug in pingora itself causing the actual issue to be addressed. |
#201