Rewrite congestion and recovery code #1490
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vkrasnov
force-pushed
the
vlad/gcongestion
branch
from
76afb3b
to
560010f
Compare
This is a very large change that replaces most of the congestion and recovery control implementation with an implementation that copies google/quiche for the most part. Most importantly cubic and pacing are copied exactly from google/quiche so we can have a high confidence in both. This fixes our pacing problems entirely and also has a much cleaner interface, where every bit is cleanly separated from the main state.
vkrasnov
force-pushed
the
vlad/gcongestion
branch
from
560010f
to
0ccca19
Compare
|
Survived by #1742 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a significant change that replaces most of the congestion and recovery control implementation with an implementation that mostly ports the one from google/quiche. IMHO The change nicely breaks up congestion, recovery and pacing into separate, easily mainatinable and extensible pieces, and is also more idiomatic. The advantage of porting from google/quiche is that at least the cubic and pacing codes are very well tested, and require minimal review. The new pacing implementaion is also more accurate.