CI: disable nightly rustfmt (tmp) #541
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since nightly rustfmt is not coming back a week, disable it temporarily. https://rust-lang.github.io/rustup-components-history/
|
It looks like rustfmt will be fixed soon (rust-lang/rust#72671) so this is not needed anymore I think. Though for the future, instead of disabling rustfmt, a better fix would be to pin to an older nightly version that has the required components, like so: commit e3718528cb9ad9c2550c6eeef564ac3d0ad8d7a3 (HEAD -> travis-nightly, origin/travis-nightly)
Author: Alessandro Ghedini <alessandro@ghedini.me>
Date: Fri May 29 15:15:33 2020 +0100
travis: pin rust nightly to latest with rustfmt
diff --git a/.travis.yml b/.travis.yml
index 15c6d8ab..6a1994bb 100644
--- a/.travis.yml
+++ b/.travis.yml
@@ -51,7 +51,7 @@ matrix:
- make docker-build
- name: "nightly Linux x86_64"
language: rust
- rust: nightly
+ rust: nightly-2020-05-14
addons:
apt:
packages: |
|
Sure. Your patch should work too. I'll close this one once rustfmt is back today or tomorrow. |
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since nightly rustfmt is not coming back a week, disable it
temporarily.
https://rust-lang.github.io/rustup-components-history/