Allow the usage of a callback for Listen and ListenPacket #56
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sometimes, it is useful to customize the listening connections, while the `ListenConfig` object allows to do this to some extent, it has the limitation to be shared by all connections managed by an Upgrader object. This is a problem if only some particular connections have to be customized in a specific way. This commit adds new methods where the user has to provide callbacks that are responsible to open the connection when needed.
…thods Removes the code duplication introduced by these new methods. Now the old `Listen`/`ListenPacket` methods are just using the `WithCallback` variants under the hood.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
ListenConfigapproach added recently works well if all the connections are similar, but when different configs are required for specific connections, it quickly gets very cumbersome to use.This new approach allows arbitrary callbacks to be used for each connection.
Note that this approach (as well as the
ListenConfigone) have one drawback: if the connection customization logic changes, from one version to the next, the listening sockets will still be inherited and untouched. In this case a full service restart is necessary as the code doesn't attempt to cope with this situation.