-
Notifications
You must be signed in to change notification settings - Fork 592
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for external evaluation as a new access group rule #1625
Add support for external evaluation as a new access group rule #1625
Conversation
Oops! It looks like no changelog entry is attached to this PR. Please include a release note as described in https://github.com/cloudflare/terraform-provider-cloudflare/blob/master/docs/changelog-process.md. Example:
If you do not require a release note to be included, please add the |
thanks! can you please add some test coverage to this so that when the upstream change is merged, we can merge this one soon after? |
986baa7
to
2613744
Compare
Thanks for the feedback! Just pushed a new commit with tests, documentation and the changelog entry. |
i'll give the acceptance tests a run tomorrow first thing. today got away from me with other reviews. |
Co-authored-by: Jacob Bednarz <jacob.bednarz@hey.com>
external_evaluation = "example@example.com" | ||
external_evaluation { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
external_evaluation = "example@example.com" | |
external_evaluation { | |
external_evaluation { |
acceptance tests all passing with cloduflare-go shimmed in
just pending the upstream merge now. |
Oops, sorry for accidently closing the branch. Just wanted to thank you @jacobbednarz for the tests and changing the markdown. |
This functionality has been released in v3.16.0 of the Terraform Cloudflare Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you! |
The new external evaluation access group rule has been added to the Access backend, this PR add this functionality to Terraform to match the backend.
Related necessary Cloudflare-go PR: cloudflare/cloudflare-go#882