Skip to content
This repository has been archived by the owner on Jul 22, 2020. It is now read-only.

unsee_collected_alerts should include receiver #130

Closed
prymitive opened this issue Jul 6, 2017 · 0 comments
Closed

unsee_collected_alerts should include receiver #130

prymitive opened this issue Jul 6, 2017 · 0 comments
Assignees
@prymitive
Labels
enhancement

Comments

@prymitive
Copy link
Contributor

From #128#issuecomment-313331723

Would it be an idea to have the unsee_collected_alerts split into which receiver they are for? As it is right now it's just a total number of all alerts received for the system, but adding the receiver as a dimension would allow different teams using the same Alertmanager instance to dig into how many alerts they currently have going off.

Seems like a good idea, but current code doesn't make it easy to add.
@prymitive prymitive self-assigned this Jul 6, 2017
@prymitive prymitive mentioned this issue Jul 6, 2017
Merged
prymitive added a commit that referenced this issue Jul 9, 2017
@prymitive
Re-implement metrics calculation as a collector
c93d122 
Split metrics code into a collector, this way it's self contained and doesn't require mixing metric calculation in the main logic.
Fixes #130
@prymitive prymitive mentioned this issue Jul 9, 2017
Merged
prymitive added a commit that referenced this issue Jul 10, 2017
@prymitive
Re-implement metrics calculation as a collector
9b5155e 
Split metrics code into a collector, this way it's self contained and doesn't require mixing metric calculation in the main logic.
Fixes #130
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@prymitive prymitive

Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@prymitive