Apply tailwind #16
Apply tailwind #16
Conversation
frontend/src/theme.scss
Outdated
| @@ -0,0 +1,15 @@ | |||
|
|
|||
There was a problem hiding this comment.
@jculvey I think that we might want to remove this file as well, right?
(if so, do you prefer me to do it now or in a followup PR?)
There was a problem hiding this comment.
Yeah, if we're not using any of that stuff anymore go for it. Better to do it now I think to make sure we've covered our bases.
There was a problem hiding this comment.
no, it is being used, that's why I kept it
so I can either remove it and remove the scss code using its sass variables, or I can just remove it and replace usages of its sass variables with the hardcoded values
I think it's mostly used for the colors, I guess I can try to completely remove it alongside the variables usages and check that it doesn't break the ui too much, if it does I can hardcode the values or try to apply some tailwind classes
There was a problem hiding this comment.
I did a bit of both (removed things that didn't require a complex refactoring and replaced variables with hardcoded values everywhere else)
(you can see the specific commit here: 362304f)
| @@ -27,7 +27,7 @@ export default component$(() => { | |||
| </div> | |||
| )} | |||
| <div class={`w-full ${showColumns ? 'max-w-lg' : ''}`}> | |||
| <div class={`bg-slate-800 ${showColumns ? 'rounded ' : 'min-h-dscreen'}`}> | |||
There was a problem hiding this comment.
dscreen was my invention 🙈
@jculvey with tailwind things do look quite similar to our current version but we do need to tweak some stuff (especially spacing), but I feel like this is good enough to get merged as is (and we can gradually improve things), please check it out locally and let me know what you think 🙂