-
Notifications
You must be signed in to change notification settings - Fork 289
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
macos: Allow compiling on catalina to ventura
Signed-off-by: Dhi Aurrahman <dio@rockybars.com>
- Loading branch information
Showing
2 changed files
with
36 additions
and
0 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
35 changes: 35 additions & 0 deletions
35
patches/v8/0006-bazel-Allow-compiling-on-macOS-catalina-and-ventura.patch
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,35 @@ | ||
From 79e1d8e03c54f2b1fa1795ad5383fb0c7a94e742 Mon Sep 17 00:00:00 2001 | ||
From: Dhi Aurrahman <dio@rockybars.com> | ||
Date: Thu, 27 Oct 2022 12:45:05 +0700 | ||
Subject: [PATCH] [bazel] Allow compiling on macOS catalina and ventura | ||
|
||
Signed-off-by: Dhi Aurrahman <dio@rockybars.com> | ||
--- | ||
bazel/defs.bzl | 12 ++++++++++++ | ||
1 file changed, 12 insertions(+) | ||
|
||
diff --git a/bazel/defs.bzl b/bazel/defs.bzl | ||
index e957c0fad3..b557471eba 100644 | ||
--- a/bazel/defs.bzl | ||
+++ b/bazel/defs.bzl | ||
@@ -151,6 +151,18 @@ def _default_args(): | ||
"-fno-integrated-as", | ||
], | ||
"//conditions:default": [], | ||
+ }) + select({ | ||
+ "@v8//bazel/config:is_macos": [ | ||
+ # The clang available on macOS Catalina has a warning that isn't clean on v8 code. | ||
+ # The warning doesn't show up with more recent clangs, so disable it for now. | ||
+ "-Wno-range-loop-analysis", | ||
+ | ||
+ # To supress warning on deprecated declaration on v8 code: | ||
+ # src/base/platform/platform-darwin.cc:56:22: | ||
+ # 'getsectdatafromheader_64' is deprecated: first deprecated in macOS 13.0. | ||
+ "-Wno-deprecated-declarations", | ||
+ ], | ||
+ "//conditions:default": [], | ||
}), | ||
includes = ["include"], | ||
linkopts = select({ | ||
-- | ||
2.39.0 |