-
Notifications
You must be signed in to change notification settings - Fork 293
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Log Actor ID on V8 deserialization errors #1354
Conversation
I’m going to want to put things in the SetupParams struct that must be moved out in order to be used. As such, some of the things in the params member would be valid and some things would be invalid after running the constructor. Rather than have to document this mess, it’s better to treat the SetupParams as something only the constructor has access to and save away everything else we need other data member.
CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yep, seems reasonable to me!
I have read the CLA Document and I hereby sign the CLA |
recheck |
4ce3b95
to
d991cdf
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM assuming CI is green
I will need to put things in the SetupParams struct that are only moveable. As such, we’ll want the params parameter to be an rvalue reference so the compiler can give us hints to move the struct into place.
I’m going to want to use this to make an Actor stub in a test.
I need to test something that requires IoContexts that have Actors associated with them. The easiest way to do this was to extend the TestFixture to create a stubbed out Actor for us.
When V8 deserialization fails, it’s likely due to corruption somewhere between the Actor in JS and the storage layer. In order to aid debugging, log the actor id if we know of one.
d991cdf
to
2bdbe17
Compare
be056d0 included in the push should fix the CI problems. |
When V8 deserialization fails, it’s likely due to corruption somewhere
between the Actor in JS and the storage layer. In order to aid
debugging, log the actor id if we know of one.