Document the runtime dependencies of workerd
#170
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mrbbot
reviewed
Nov 14, 2022
README.md
Outdated
| * On Linux: | ||
| * libc++ (e.g. the package `libc++1` on Debian Bullseye) | ||
| * On macOS: | ||
| * full XCode 13+ installation |
There was a problem hiding this comment.
Wow! Do we really need a full XCode installation here?
There was a problem hiding this comment.
That's maybe badly phrased on my part—I think xcode-select --install (i.e. the command line tools, but not the GUI) should suffice.
There was a problem hiding this comment.
If you can verify that @penalosa and make that change, I'll review and get this landed.
There was a problem hiding this comment.
I don't have the XCode GUI installed, and can run workerd fine, so that may be enough to verify it (I have installed the command line tools).
There was a problem hiding this comment.
I've also added a line about running in GitHub actions, since ubuntu 20 is causing some issues
jasnell
approved these changes
Nov 15, 2022
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.