Define macOS 11 as earliest supported version #789
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Nice! Tentatively approving, but I'd like to test this on actual hardware before merging. 👍 |
macOS 11 is the oldest version still being maintained, V8 also depends on multithreading-related functions introduced with it.
fhanau
force-pushed
the
felix/mmacosx-version-min
branch
from
6dc53f7
to
1ed9330
Compare
mrbbot
approved these changes
Jun 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
macOS 11 is the oldest version still being maintained, V8 also depends on multithreading-related functions introduced with it. This is hopefully sufficient to fix cloudflare/workers-sdk#3307 cloudflare/workers-sdk#3315 cloudflare/workers-sdk#3432 – macOS shouldn't require static linking of system libraries and at least two of the issues are on macOS 11.
Also updated the readme, the
ubuntu-latestGithub Actions runner image is now identical to ubuntu-22.04 so it works just fine. Based on #170 the commend-line tools should be sufficient for compiling.