fix: KV not setting correctly (#964)

The KV has URL inputs, which in the case of `/` would get collapsed and lost. To handle special characters `encodeURIComponent` is implemented.

resolves #961

.changeset/shy-owls-count.md

@@ -0,0 +1,9 @@
+---
+"wrangler": patch
+---
+
+fix: KV not setting correctly
+The KV has URL inputs, which in the case of `/` would get collapsed and lost.
+T:o handle special characters `encodeURIComponent` is implemented.
+
+resolves #961

packages/wrangler/src/__tests__/kv.test.ts

@@ -257,6 +257,14 @@ describe("wrangler", () => {
         expect(requests.count).toEqual(1);
       });
 
+      it("should encode URI id properly for deleting namespace", async () => {
+        const requests = mockDeleteRequest("%2Fvoyager");
+        await runWrangler(`kv:namespace delete --namespace-id /voyager`);
+        expect(requests.count).toEqual(1);
+        expect(std.out).toMatchInlineSnapshot(`""`);
+        expect(std.err).toMatchInlineSnapshot(`""`);
+      });
+
       it("should delete a namespace specified by binding name", async () => {
         writeWranglerConfig();
         const requests = mockDeleteRequest("bound-id");
@@ -381,6 +389,21 @@ describe("wrangler", () => {
         expect(std.err).toMatchInlineSnapshot(`""`);
       });
 
+      it("should encode URI key's properly for putting in a key request", async () => {
+        const requests = mockKeyPutRequest("DS9", {
+          key: "%2Fmy-key",
+          value: "my-value",
+        });
+
+        await runWrangler("kv:key put /my-key my-value --namespace-id DS9");
+
+        expect(requests.count).toEqual(1);
+        expect(std.out).toMatchInlineSnapshot(
+          `"Writing the value \\"my-value\\" to key \\"/my-key\\" on namespace DS9."`
+        );
+        expect(std.err).toMatchInlineSnapshot(`""`);
+      });
+
       it("should put a key in a given namespace specified by binding", async () => {
         writeWranglerConfig();
         const requests = mockKeyPutRequest("bound-id", {
@@ -1078,6 +1101,16 @@ describe("wrangler", () => {
         expect(requests.count).toEqual(1);
       });
 
+      it("should encode the URI properly for deleting a key requests", async () => {
+        const requests = mockDeleteRequest("voyager", "%2FNCC-74656");
+        await runWrangler(`kv:key delete --namespace-id voyager /NCC-74656`);
+        expect(requests.count).toEqual(1);
+        expect(std.out).toMatchInlineSnapshot(
+          `"Deleting the key \\"/NCC-74656\\" on namespace voyager."`
+        );
+        expect(std.err).toMatchInlineSnapshot(`""`);
+      });
+
       it("should delete a key in a namespace specified by binding name", async () => {
         writeWranglerConfig();
         const requests = mockDeleteRequest("bound-id", "someKey");

packages/wrangler/src/index.tsx

@@ -2016,7 +2016,9 @@ export async function main(argv: string[]): Promise<void> {
             const accountId = await requireAuth(config);
 
             await fetchResult<{ id: string }>(
-              `/accounts/${accountId}/storage/kv/namespaces/${id}`,
+              `/accounts/${accountId}/storage/kv/namespaces/${encodeURIComponent(
+                id
+              )}`,
               { method: "DELETE" }
             );
 
@@ -2270,7 +2272,9 @@ export async function main(argv: string[]): Promise<void> {
             const accountId = await requireAuth(config);
 
             await fetchResult(
-              `/accounts/${accountId}/storage/kv/namespaces/${namespaceId}/values/${key}`,
+              `/accounts/${accountId}/storage/kv/namespaces/${namespaceId}/values/${encodeURIComponent(
+                key
+              )}`,
               { method: "DELETE" }
             );
           }

packages/wrangler/src/kv.ts

@@ -151,7 +151,9 @@ export async function putKeyValue(
     }
   }
   return await fetchResult(
-    `/accounts/${accountId}/storage/kv/namespaces/${namespaceId}/values/${keyValue.key}`,
+    `/accounts/${accountId}/storage/kv/namespaces/${namespaceId}/values/${encodeURIComponent(
+      keyValue.key
+    )}`,
     { method: "PUT", body: keyValue.value },
     searchParams
   );