fix: KV not setting correctly #964
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The KV has URL inputs, which in the case of `/` would get collapsed and lost. To handle special characters `encodeURIComponent` is implemented. resolves #961
JacobMGEvans
requested review from
threepointone and
petebacondarwin
as code owners
🦋 Changeset detectedLatest commit: e719993 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
A wrangler prerelease is available for testing. You can install this latest build in your project with: npm install --save-dev https://prerelease-registry.developers.workers.dev/runs/2308072889/npm-package-wrangler-964You can reference the automatically updated head of this PR with: npm install --save-dev https://prerelease-registry.developers.workers.dev/prs/964/npm-package-wrangler-964Or you can use npx https://prerelease-registry.developers.workers.dev/runs/2308072889/npm-package-wrangler-964 dev path/to/script.js |
threepointone
approved these changes
May 11, 2022
Merged
|
|
||
| fix: KV not setting correctly | ||
| The KV has URL inputs, which in the case of `/` would get collapsed and lost. | ||
| T:o handle special characters `encodeURIComponent` is implemented. |
threepointone
added a commit
that referenced
this pull request
May 13, 2022
… a namespace This cleans up some logic from #964. - we shouldn't be encoding the id when deleting a namespace, since that'll already be an alphanumeric id - we should be encoding the key when we call kv:key get, or we get a similar issue as in #961 - adds `KV` to all the KV-related function names - moves the api calls to `kv:namespace delete` and `kv:key delete` inside `kv.ts` helpers.
threepointone
added a commit
that referenced
this pull request
May 13, 2022
… a namespace (#987) This cleans up some logic from #964. - we shouldn't be encoding the id when deleting a namespace, since that'll already be an alphanumeric id - we should be encoding the key when we call kv:key get, or we get a similar issue as in #961 - adds `KV` to all the KV-related function names - moves the api calls to `kv:namespace delete` and `kv:key delete` inside `kv.ts` helpers.
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The KV has URL inputs, which in the case of
/would get collapsed and lost. To handle special charactersencodeURIComponentis implemented.resolves #961